[SPARK-48355][SQL][TESTS][FOLLOWUP] Enable a SQL Scripting test in ANSI and non-ANSI modes #48194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
dongjoon-hyun
approved these changes
Sep 22, 2024
HyukjinKwon
approved these changes
Sep 22, 2024
|
Merged to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…SI and non-ANSI modes ### What changes were proposed in this pull request? In the PR, I propose to enable the test which apache#48115 turned off, and run in the ANSI and non-ANSI modes. ### Why are the changes needed? To make this test stable, and don't depend on the default setting for ANSI mode. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the modified test locally: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.scripting.SqlScriptingInterpreterSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48194 from MaxGekk/enable-sqlscript-test-ansi. Authored-by: Max Gekk <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…SI and non-ANSI modes ### What changes were proposed in this pull request? In the PR, I propose to enable the test which apache#48115 turned off, and run in the ANSI and non-ANSI modes. ### Why are the changes needed? To make this test stable, and don't depend on the default setting for ANSI mode. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the modified test locally: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.scripting.SqlScriptingInterpreterSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48194 from MaxGekk/enable-sqlscript-test-ansi. Authored-by: Max Gekk <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to enable the test which #48115 turned off, and run in the ANSI and non-ANSI modes.
Why are the changes needed?
To make this test stable, and don't depend on the default setting for ANSI mode.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test locally:
Was this patch authored or co-authored using generative AI tooling?
No.